Skip to content

issue-1083 #1090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 4, 2021
Merged

issue-1083 #1090

merged 3 commits into from
Mar 4, 2021

Conversation

yoution
Copy link
Contributor

@yoution yoution commented Mar 1, 2021

No description provided.

@yoution
Copy link
Contributor Author

yoution commented Mar 1, 2021

@maxceem please review

@yoution yoution mentioned this pull request Mar 1, 2021
Closed
maxceem
maxceem suggested changes Mar 3, 2021
View reviewed changes
Copy link
Contributor

@maxceem maxceem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yoution All good, but could we please slightly update the style, so it's easier to see the main error like this:

image

  • alight left
  • font size of error 25px
  • add word Error: before the error message

@yoution yoution requested a review from maxceem March 3, 2021 13:22
maxceem
maxceem suggested changes Mar 3, 2021
View reviewed changes
Copy link
Contributor

@maxceem maxceem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yoution sorry if I was not clear.

I mean keep the black title There was an error loading the challenge. And show the big error message inside the rectangle. So to make it the same like on the screenshot:

image

@yoution yoution requested a review from maxceem March 4, 2021 01:01
maxceem
maxceem approved these changes Mar 4, 2021
View reviewed changes
Copy link
Contributor

@maxceem maxceem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for all the updates @yoution. Looks perfect now.

@maxceem maxceem merged commit e9c57a3 into topcoder-platform:develop Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxceem maxceem maxceem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yoution @maxceem